Fix incorrect handling of UNTIL if falling into DST change and some related improvements #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and to avoid expensive timezone operations.
…me` which can easily be confusing and error prone.
…s with DST changes.
minichma
force-pushed
the
work/minichma/bugfix/until_tzconversion
branch
from
77a049e to
124cb51
Compare
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (75%) is below the target coverage (80%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #738 +/- ##
===================================
- Coverage 66% 66% -0%
===================================
Files 105 105
Lines 4649 4633 -16
Branches 1151 1144 -7
===================================
- Hits 3073 3054 -19
+ Misses 1142 1139 -3
- Partials 434 440 +6
|
minichma
changed the title
axunonb
approved these changes
Mar 2, 2025
Collaborator
axunonb
left a comment
axunonb
left a comment
There was a problem hiding this comment.
Nice, thanks. Sorry for the delay.
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce and fix #736. I.e. if
UNTILfalls into a DST change with ambiguity, then recurrences could have missed, which is fixed with this PR.Other improvements include:
System.DateTimetoCalDateTime, which could cause confusion and was a source of bugs.AsUtcfromCalDateTime.GetHashCode()to avoid timezone calculationsCalDateTimeif they have the sameTzId